tags: #publish links: [[Management]] created: 2021-07-05 Mon --- # How to do code review https://google.github.io/eng-practices/review/reviewer/ https://google.github.io/eng-practices/review/reviewer/looking-for.html https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/cr_respect.md https://www.atlassian.com/blog/git/written-unwritten-guide-pull-requests ## Topics for reviewers - Design - Functionality - Complexity - Tests - Naming - Comments - Style - Consistency - Documentation - In the PR - What else needs to be updated? Have they? - Every Line - Expectation is to look at every line, unless author narrows review focus or it's junk changes - Context - Good Things - tell them if you find good things! Encouragement / reinforcement